From: Owen W. Taylor Date: Thu, 6 Aug 2009 20:26:45 +0000 (-0400) Subject: Turn on -Werror and -Wmissing-prototypes X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~11148 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e89d3c7b07b174cd67461ddbdae7e671a336a709;p=gnome-shell.git Turn on -Werror and -Wmissing-prototypes When compiling with GCC turn on -Wmissing-prototypes, and by default turn on -Werror as well. As with most gnome modules: --enable-compile-warnings=minimum/maximum Can be used to disable -Werror (they are the same) http://bugzilla.gnome.org/show_bug.cgi?id=590998 --- diff --git a/configure.ac b/configure.ac index 571297a7b..ef64a230f 100644 --- a/configure.ac +++ b/configure.ac @@ -80,17 +80,31 @@ AC_SUBST(GIRDIR) TYPELIBDIR="$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)" AC_SUBST(TYPELIBDIR) +# Stay command-line compatible with the gnome-common configure option. Here +# minimum/yes/maximum are the same, however. +AC_ARG_ENABLE(compile_warnings, + AC_HELP_STRING([--enable-compile-warnings=@<:@no/minimum/yes/maximum/error@:>@], + [Turn on compiler warnings]),, + enable_compile_warnings=error) + changequote(,)dnl -if test "x$GCC" = "xyes"; then - case " $CFLAGS " in - *[\ \ ]-Wall[\ \ ]*) ;; - *) CFLAGS="$CFLAGS -Wall" ;; - esac - - case " $OBJCFLAGS " in - *[\ \ ]-Wall[\ \ ]*) ;; - *) OBJCFLAGS="$OBJCFLAGS -Wall" ;; - esac +if test "$enable_compile_warnings" != no ; then + if test "x$GCC" = "xyes"; then + case " $CFLAGS " in + *[\ \ ]-Wall[\ \ ]*) ;; + *) CFLAGS="$CFLAGS -Wall" ;; + esac + case " $CFLAGS " in + *[\ \ ]-Wmissing-prototypes[\ \ ]*) ;; + *) CFLAGS="$CFLAGS -Wmissing-prototypes" ;; + esac + if test "$enable_compile_warnings" = error ; then + case " $CFLAGS " in + *[\ \ ]-Werror[\ \ ]*) ;; + *) CFLAGS="$CFLAGS -Werror" ;; + esac + fi + fi fi changequote([,])dnl